refactor(cli, nvim): add exit code to job runners.#160
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 22 22
Lines 1513 1519 +6
=======================================
+ Hits 1502 1508 +6
Misses 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 4 commits
May 29, 2025 10:16
Davidyz
force-pushed
the
nvim/jobrunner_exitcode
branch
from
10178bb to
fbf5029
Compare
Davidyz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to eliminate all usage of
vim.systemand/orplenary.joboutside of jobrunners.Also, this PR improved error handling of the LSP server so that the error codes follow the LSP specification.